Refactor git command stderr handling (#36402)

And clean up legacy fragile & incorrect logic
2026-01-19 07:10:33 +08:00
parent fafd1db19e
commit 72be55f7d3
69 changed files with 345 additions and 627 deletions
@@ -20,10 +20,10 @@ func synchronizeRepoHeads(ctx context.Context, logger log.Logger, autofix bool)
 	numReposUpdated := 0
 	err := iterateRepositories(ctx, func(repo *repo_model.Repository) error {
 		numRepos++
-		_, defaultBranchErr := gitrepo.RunCmdString(ctx, repo,
+		_, _, defaultBranchErr := gitrepo.RunCmdString(ctx, repo,
 			gitcmd.NewCommand("rev-parse").AddDashesAndList(repo.DefaultBranch))

-		head, headErr := gitrepo.RunCmdString(ctx, repo,
+		head, _, headErr := gitrepo.RunCmdString(ctx, repo,
 			gitcmd.NewCommand("symbolic-ref", "--short", "HEAD"))

 		// what we expect: default branch is valid, and HEAD points to it