migrate to AG-UI state sync

ui/test/tbd/ui/core_test.cljs

@@ -57,6 +57,9 @@
           (is (= (set (map :name webmcp/tools)) (tools-in-widget)) "it offers the page's tools to the agent")
           (is (= (map :name (remove :pages webmcp/tools)) (map :name (model-context/definitions :ai-setup)))
               "and to the chatbot, the ones of the page it is on")
+          (is (= {:board (vec (repeat 9 nil)) :status "in_progress" :turn :x}
+                 (model-context/current-state :tic-tac-toe))
+              "and its state, for the page it starts on")
           ;; A tool, as the agent's client calls it.
           (let [ping (.-execute (.get (.-availableTools ^js (widget)) "ping"))]
             (-> (ping #js {})

ui/test/tbd/ui/events_test.cljs

@@ -25,10 +25,12 @@
    :after model-context/clear!}
   (tu/stub-effects-fixture {::events/fetch (record ::events/fetch)
                             ::events/fetch-stream (record ::events/fetch-stream)
+                            ::events/persist-chat (record ::events/persist-chat)
                             ::events/call-tools (record ::events/call-tools)
                             ::events/copy-to-clipboard (record ::events/copy-to-clipboard)
                             :dispatch-later (record :dispatch-later)
-                            :dispatch #(swap! queued conj %)}))
+                            :dispatch #(swap! queued conj %)
+                            :dispatch-n #(swap! queued into %)}))
 
 (defn- dispatch!
   "Dispatches `event` and, one after the other, the events it sets off."
@@ -49,6 +51,14 @@
 
 (defn- last-request [] (last (requests)))
 
+(defn- persist-requests
+  "The chat history save/clear requests asked for so far (see ::events/persist-chat), as
+  {:uri :method :body :on-response}."
+  []
+  (mapv second (filter (comp #{::events/persist-chat} first) @effects)))
+
+(defn- last-persist-request [] (last (persist-requests)))
+
 (defn- answer!
   "The server answers the last request."
   ([status body] (answer! (last-request) status body))
@@ -162,10 +172,11 @@
 ;; --- Login ---
 
 (deftest user-response-test
-  (testing "logged in: remembers who, and loads the todos"
+  (testing "logged in: remembers who, loads the todos, and asks for the last chat session"
     (start!)
     (answer! 200 {:login "alice" :id 7})
     (is (= {:status :logged-in :login "alice"} (:user (app-db))))
+    (is (= #{"/auth/me" "/api/todos" "/api/chat/history"} (set (map :uri (requests)))))
     (is (= "/api/todos" (:uri (last-request)))))
   (testing "401 only means nobody is logged in"
     (start!)
@@ -338,8 +349,7 @@
   (logged-in! [])
   (say! "  hello there ")
   (testing "the trimmed message joins the conversation and goes to the server, for a stream back"
-    (let [[effect request] (last @effects)]
-      (is (= ::events/fetch-stream effect))
+    (let [request (last-request)]
       (is (= "/api/chat" (:uri request)))
       (is (= "POST" (:method request)))
       (is (= [::events/chat-event] (:on-event request)))
@@ -347,7 +357,11 @@
       (is (= [{:role "user" :content "hello there"}] (sent-messages request)))
       (is (= [{:description "page" :value "tic-tac-toe"}] (get-in request [:body :context]))))
     (is (= {:messages [{:role "user" :content "hello there"}] :input "" :status :loading :error nil}
-           (select-keys (chat) [:messages :input :status :error]))))
+           (select-keys (chat) [:messages :input :status :error])))
+    (testing "and is saved for the next login, right away (not only once the reply comes)"
+      (is (= {:uri "/api/chat/history" :method "PUT"
+              :body {:messages [{:role "user" :content "hello there"}]}}
+             (select-keys (last-persist-request) [:uri :method :body])))))
   (testing "only one message is in flight, so sending again does nothing"
     (say! "and another")
     (is (= 1 (count (requests))))
@@ -532,7 +546,41 @@
   (event! {:done true})
   (dispatch! [::events/chat-toggle])
   (dispatch! [::events/chat-clear])
-  (is (= (assoc (:chat db/default-db) :open? true) (chat)) "starts over, and the panel stays as it was"))
+  (is (= (assoc (:chat db/default-db) :open? true) (chat)) "starts over, and the panel stays as it was")
+  (testing "the stored session goes with it, so a reload doesn't bring the old conversation back"
+    (is (= {:uri "/api/chat/history" :method "DELETE"} (select-keys (last-persist-request) [:uri :method])))))
+
+(deftest chat-history-restore-test
+  (testing "the last session comes back, once, right after login"
+    (start!)
+    (answer! 200 {:login "alice" :id 7})
+    (let [history-request (first (filter #(= "/api/chat/history" (:uri %)) (requests)))
+          messages [{:role "user" :content "hi"} {:role "assistant" :content "echo: hi"}]]
+      (answer! history-request 200 {:messages messages})
+      (answer! 200 {:todos []})
+      (is (= messages (:messages (chat))))))
+  (testing "an empty history leaves the conversation empty"
+    (start!)
+    (answer! 200 {:login "bob" :id 8})
+    (let [history-request (first (filter #(= "/api/chat/history" (:uri %)) (requests)))]
+      (answer! history-request 200 {:messages []})
+      (answer! 200 {:todos []})
+      (is (= [] (:messages (chat))))))
+  (testing "a conversation already started (the response arriving late) is not overwritten"
+    (start!)
+    (answer! 200 {:login "alice" :id 7})
+    (let [history-request (first (filter #(= "/api/chat/history" (:uri %)) (requests)))]
+      (answer! 200 {:todos []})
+      (say! "already started")
+      (answer! history-request 200 {:messages [{:role "user" :content "old session"}]})
+      (is (= [{:role "user" :content "already started"}] (:messages (chat))))))
+  (testing "a failed load (a 401, say) just leaves the conversation empty"
+    (start!)
+    (answer! 200 {:login "alice" :id 7})
+    (let [history-request (first (filter #(= "/api/chat/history" (:uri %)) (requests)))]
+      (answer! history-request 401 {:error "login required"})
+      (answer! 200 {:todos []})
+      (is (= [] (:messages (chat)))))))
 
 (deftest chat-toggle-tools-test
   (logged-in! [])
@@ -618,6 +666,27 @@
     (is (= [{:name "add" :description "Adds" :parameters add-schema}]
            (:tools (:body (last-request)))))))
 
+(deftest chat-offers-the-state-test
+  (logged-in! [])
+  (testing "no state provider on the page, none offered"
+    (say! "hi")
+    (is (not (contains? (:body (last-request)) :state))))
+  (testing "the page's state goes along with the conversation, as tbd.chat.schema/RunAgentInput's state"
+    (reply! "hello")
+    (model-context/register-state! [{:provide (fn [] {:board (vec (repeat 9 nil))})}])
+    (say! "again")
+    (is (= {:board (vec (repeat 9 nil))} (:state (:body (last-request))))))
+  (testing "a provider offered on another page adds nothing here"
+    (reply! "hello")
+    (model-context/register-state! [{:provide (fn [] {:todos []}) :pages #{:todos}}])
+    (say! "once more")
+    (is (not (contains? (:body (last-request)) :state))))
+  (testing "a provider that has nothing to say (nil) adds nothing"
+    (reply! "hello")
+    (model-context/register-state! [{:provide (fn [] nil)}])
+    (say! "again")
+    (is (not (contains? (:body (last-request)) :state)))))
+
 (defn- page-of [request]
   (some #(when (= "page" (:description %)) (:value %)) (get-in request [:body :context])))
 

ui/test/tbd/ui/model_context_test.cljs

@@ -122,6 +122,20 @@
           (fn [_] (is (= [:tic-tac-toe-only :everywhere] @ran) "and never run")))
         done))))
 
+(deftest current-state-test
+  (testing "nothing registered, nothing to offer"
+    (is (= {} (model-context/current-state :todos))))
+  (model-context/register-state! [{:provide (fn [] {:todos [{:title "milk"}]}) :pages #{:todos}}
+                                   {:provide (fn [] {:board (vec (repeat 9 nil))}) :pages #{:tic-tac-toe}}
+                                   {:provide (fn [] {:page-status "ok"})}])
+  (testing "only the providers offered on the page run, merged into one map"
+    (is (= {:todos [{:title "milk"}] :page-status "ok"} (model-context/current-state :todos)))
+    (is (= {:board (vec (repeat 9 nil)) :page-status "ok"} (model-context/current-state :tic-tac-toe)))
+    (is (= {:page-status "ok"} (model-context/current-state :calculator))))
+  (testing "clear! takes state providers away too"
+    (model-context/clear!)
+    (is (= {} (model-context/current-state :todos)))))
+
 (deftest call-failures-test
   (let [ran? (atom false)]
     (model-context/register! [(tool "t" (fn [_] (reset! ran? true) "ran"))])

ui/test/tbd/ui/test_util.cljs

@@ -76,6 +76,13 @@
                                  {:content "echo: "}
                                  {:content (:content (last (:messages body)))}
                                  {:done true}]))))
+      (and (= "GET" method) (= "/api/chat/history" uri)) (respond 200 {:messages (:chat-history @server [])})
+      (and (= "PUT" method) (= "/api/chat/history" uri))
+      (do (swap! server assoc :chat-history (:messages body))
+          (respond 200 {:saved true}))
+      (and (= "DELETE" method) (= "/api/chat/history" uri))
+      (do (swap! server assoc :chat-history [])
+          (respond 200 {:cleared true}))
       (and (= "GET" method) (= "/api/todos" uri)) (respond 200 {:todos todos})
       (and (= "POST" method) (= "/api/todos" uri))
       (if (seq (.trim (:title body)))

ui/test/tbd/ui/views_test.cljs

@@ -828,8 +828,10 @@
             #(tu/eventually (fn [] (= ["what is 2 + 3? use the calculator" "I'll add them." "2 + 3 is 5."]
                                       (chat-messages))))
             (fn [_]
-              (testing "the LLM was told about the tools of the page it was on (the calculator), not all of them"
-                (is (= (set (map :name (filter #(contains? (or (:pages %) #{:calculator}) :calculator) webmcp/tools)))
+              (testing "the LLM was told about the tools of the page it was on (the calculator), not all of them,
+                       and not the read-only ones (get_calculator): its state covers those"
+                (is (= (set (map :name (remove :read-only? (filter #(contains? (or (:pages %) #{:calculator}) :calculator)
+                                                                    webmcp/tools))))
                        (set (map :name (:tools (first (:chat-requests @tu/server))))))))
               (testing "the page made the call, as a user would: the calculator holds what was typed and its sum"
                 (is (= {:x "2" :y "3" :result {:status :ok :x "2" :y "3" :sum 5}}

ui/test/tbd/ui/webmcp_test.cljs

@@ -225,9 +225,7 @@
     (-> (call "whoami" {})
         (.then (fn [_] (call "set_todo_done" {:todos (mapv #(hash-map :id (tu/todo-uuid %) :done false) (range 1 4))})))
         (.then (fn [r]
-                 (is (false? (:error? r)))
-                 (is (= ["todo-1" "todo-2" "todo-3"] (map :title (json (:text r)))))
-                 (is (= [false false false] (map :done (json (:text r)))))
+                 (is (= {:text "ok" :error? false} r) "nothing left to say: the page shows it, and so will the next state")
                  (is (= [false false false] (map :done (get-in @rf-db/app-db [:todos :items]))))
                  (is (= :todos (page)))
                  ;; A bad entry, or an unknown todo, refuses the whole batch before anything changes.
@@ -254,9 +252,8 @@
     (-> (call "whoami" {})
         (.then (fn [_] (call "create_todo" {:todos [{:title "milk"} {:title "eggs"} {:title "bread"}]})))
         (.then (fn [r]
-                 (is (false? (:error? r)))
-                 (is (= ["milk" "eggs" "bread"] (map :title (json (:text r)))) "in the order given")
-                 (is (= ["milk" "eggs" "bread"] (map :title (get-in @rf-db/app-db [:todos :items]))))
+                 (is (= {:text "ok" :error? false} r))
+                 (is (= ["milk" "eggs" "bread"] (map :title (get-in @rf-db/app-db [:todos :items]))) "in the order given")
                  (is (= :todos (page)))
                  (call "get_todo" {:todos [{:id (tu/todo-uuid 3)} {:id (tu/todo-uuid 1)}]})))
         (.then (fn [r]
@@ -272,8 +269,7 @@
                  (is (= 3 (count (get-in @rf-db/app-db [:todos :items]))) "an unknown id deletes nothing")
                  (call "delete_todo" {:todos [{:id (tu/todo-uuid 1)} {:id (tu/todo-uuid 1)} {:id (tu/todo-uuid 2)}]})))
         (.then (fn [r]
-                 (is (false? (:error? r)))
-                 (is (= {:deleted [(tu/todo-uuid 1) (tu/todo-uuid 2)]} (json (:text r))) "a repeated id is deleted once")
+                 (is (= {:text "ok" :error? false} r) "a repeated id is deleted once, not refused as unknown the second time")
                  (is (= ["bread"] (map :title (get-in @rf-db/app-db [:todos :items]))))
                  (is (= ["bread"] (map :title (:todos @tu/server))))
                  ;; The server refuses a blank title, which the page only sees after the first was added.
@@ -367,27 +363,25 @@
                  (is (= {:text (str "todo not found: " (tu/todo-uuid 99)) :error? true} r))
                  (call "create_todo" {:todos [{:title "buy milk"}]})))
         (.then (fn [r]
-                 (is (false? (:error? r)))
-                 (is (= [{:id (tu/todo-uuid 2) :title "buy milk" :done false}]
-                        (map #(select-keys % [:id :title :done]) (json (:text r)))))
+                 (is (= {:text "ok" :error? false} r))
                  ;; The page shows it, and the field is empty again.
                  (is (= ["old" "buy milk"] (map :title (get-in @rf-db/app-db [:todos :items]))))
                  (is (= "" (get-in @rf-db/app-db [:todos :new-title])))
                  (call "set_todo_done" {:todos [{:id (tu/todo-uuid 2) :done true}]})))
         (.then (fn [r]
-                 (is (= [true] (map :done (json (:text r)))))
+                 (is (= {:text "ok" :error? false} r))
                  (is (true? (:done (last (get-in @rf-db/app-db [:todos :items])))))
                  ;; Already ticked: nothing to do, and no request.
                  (swap! tu/server assoc :todos [])
                  (call "set_todo_done" {:todos [{:id (tu/todo-uuid 2) :done true}]})))
         (.then (fn [r]
-                 (is (= [true] (map :done (json (:text r)))))
+                 (is (= {:text "ok" :error? false} r) "still nothing to do: the now-empty server list was never asked")
                  (call "set_todo_done" {:todos [{:id (tu/todo-uuid 2) :done "yes"}]})))
         (.then (fn [r]
                  (is (:error? r))
                  (call "delete_todo" {:todos [{:id (tu/todo-uuid 1)}]})))
         (.then (fn [r]
-                 (is (= {:text (str "{\"deleted\":[\"" (tu/todo-uuid 1) "\"]}") :error? false} r))
+                 (is (= {:text "ok" :error? false} r))
                  (is (= ["buy milk"] (map :title (get-in @rf-db/app-db [:todos :items]))))
                  (call "delete_todo" {:todos [{:id (tu/todo-uuid 1)}]})))
         (.then (fn [r]
@@ -417,10 +411,11 @@
                  (is (= {:board (vec (repeat 9 nil)) :status "in_progress" :turn "x"} (json (:text r))))
                  (call "move_tic_tac_toe" {:cell 4 :player "x"})))
         (.then (fn [r]
-                 ;; It pressed the cell, as a user would, and says it is O's turn now.
+                 ;; It pressed the cell, as a user would; there is nothing left to say (see
+                 ;; provider-for's tic-tac-toe assertions for the shape it takes in the state).
+                 (is (= {:text "ok" :error? false} r))
                  (is (= :x (get-in @rf-db/app-db [:ttt :board 4])))
-                 (is (= {:board [nil nil nil nil "x" nil nil nil nil] :status "in_progress" :turn "o"}
-                        (json (:text r))))
+                 (is (= :o (get-in @rf-db/app-db [:ttt :turn])) "it is O's turn now")
                  (call "move_tic_tac_toe" {:cell 4 :player "o"})))
         (.then (fn [r]
                  (is (= {:text "cell 4 is taken" :error? true} r))
@@ -448,21 +443,72 @@
                  (is (:error? r))
                  (call "move_tic_tac_toe" {:cell 0 :player "o"})))
         (.then (fn [r]
-                 (is (= "x" (:turn (json (:text r)))))
+                 (is (= {:text "ok" :error? false} r))
+                 (is (= :x (get-in @rf-db/app-db [:ttt :turn])))
                  ;; The person moves X to 3 and O to 1; the agent's X then completes the middle row.
                  (rf/dispatch-sync [::events/ttt-move 3])
                  (rf/dispatch-sync [::events/ttt-move 1])
                  (call "move_tic_tac_toe" {:cell 5 :player "x"})))
         (.then (fn [r]
-                 (is (= {:board ["o" "o" nil "x" "x" "x" nil nil nil]
-                         :status "won" :winner "x" :line [3 4 5]}
-                        (json (:text r))))
+                 (is (= {:text "ok" :error? false} r))
+                 (is (= [:o :o nil :x :x :x nil nil nil] (get-in @rf-db/app-db [:ttt :board])) "X won the middle row")
                  (call "move_tic_tac_toe" {:cell 8 :player "o"})))
         (.then (fn [r]
                  (is (= {:text "the game is over: start a new game" :error? true} r))
                  (call "new_tic_tac_toe_game" {})))
         (.then (fn [r]
-                 (is (= {:board (vec (repeat 9 nil)) :status "in_progress" :turn "x"} (json (:text r))))
+                 (is (= {:text "ok" :error? false} r))
+                 (is (= (vec (repeat 9 nil)) (get-in @rf-db/app-db [:ttt :board])))
+                 (is (= :x (get-in @rf-db/app-db [:ttt :turn])))
+                 (done))))))
+
+;; --- State (tbd.ui.model-context's registry, filled from webmcp/state-providers) ---
+
+(defn- provider-for
+  "The `:provide` fn of the state provider registered for exactly `pages`."
+  [pages]
+  (:provide (first (filter #(= pages (:pages %)) webmcp/state-providers))))
+
+(deftest calculator-state-provider-test
+  (open-page!)
+  (async done
+    (-> (page-loaded)
+        (.then (fn [_]
+                 (is (= {:x "" :y "" :result {:status :idle}} ((provider-for #{:calculator}))))
+                 (call "add" {:x 2 :y 3})))
+        (.then (fn [_]
+                 (is (= {:x "2" :y "3" :result {:status :ok :x "2" :y "3" :sum 5}}
+                        ((provider-for #{:calculator}))))
+                 (done))))))
+
+(deftest tic-tac-toe-state-provider-test
+  (open-page!)
+  ;; Raw, as tbd.ui.tictactoe keeps it (:x/:o, not the "x"/"o" strings get_tic_tac_toe's JSON gave:
+  ;; there is no JSON round trip here, only on the wire to the server).
+  (is (= {:board (vec (repeat 9 nil)) :status "in_progress" :turn :x} ((provider-for #{:tic-tac-toe})))
+      "the same state get_tic_tac_toe used to hand back")
+  (async done
+    (-> (call "move_tic_tac_toe" {:cell 4 :player "x"})
+        (.then (fn [_]
+                 (is (= {:board [nil nil nil nil :x nil nil nil nil] :status "in_progress" :turn :o}
+                        ((provider-for #{:tic-tac-toe}))))
+                 (done))))))
+
+(deftest todos-state-provider-test
+  (testing "nothing until the todos have loaded (no login, or not fetched yet): not an empty list,
+           which would read as \"there are none\""
+    (is (nil? ((provider-for #{:todos})))))
+  (tu/log-in!)
+  (swap! tu/server assoc :todos [{:id (tu/todo-uuid 1) :owner-id 7 :title "old" :done false :created-at 1 :updated-at 1}]
+         :next-id 2)
+  (open-page!)
+  (async done
+    (-> (call "list_todos" {}) ; waits for the load, the way logged-in-todos does
+        (.then (fn [_]
+                 (is (= {:todos [{:id (tu/todo-uuid 1) :title "old" :done false}]} ((provider-for #{:todos}))))
+                 (call "create_todo" {:todos [{:title "buy milk"}]})))
+        (.then (fn [_]
+                 (is (= ["old" "buy milk"] (map :title (:todos ((provider-for #{:todos}))))))
                  (done))))))
 
 ;; --- Prompts and resources ---